Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assertEquals converted to assertThat for MarkdownTest #2202

Merged
merged 1 commit into from
Nov 17, 2022
Merged

assertEquals converted to assertThat for MarkdownTest #2202

merged 1 commit into from
Nov 17, 2022

Conversation

smcg468
Copy link
Contributor

@smcg468 smcg468 commented Nov 16, 2022

related to #2147
Importing AssertJ and changing all assertEquals to assertThat.

Example of Change:

assertEquals(expected, markdown.parse(input));

To

assertThat(markdown.parse(input)).isEqualTo(expected);

andrerfcsantos
andrerfcsantos approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@andrerfcsantos andrerfcsantos added the x:rep/small Small amount of reputation label Nov 17, 2022
@andrerfcsantos andrerfcsantos merged commit 1fcedc6 into exercism:main Nov 17, 2022
@smcg468 smcg468 deleted the markdown-assertJ-conversion branch November 18, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerfcsantos andrerfcsantos andrerfcsantos approved these changes

Assignees
No one assigned
Labels
x:rep/small Small amount of reputation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smcg468 @andrerfcsantos